Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable toolchain resolution for filegroup targets. #12901

Closed
wants to merge 1 commit into from
Closed

Enable toolchain resolution for filegroup targets. #12901

wants to merge 1 commit into from

Conversation

katre
Copy link
Member

@katre katre commented Jan 26, 2021

Fixes #12899.

@google-cla google-cla bot added the cla: yes label Jan 26, 2021
@katre
Copy link
Member Author

katre commented Jan 26, 2021

Ran downstream tests: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1886

The only failure is also at HEAD.

@katre katre mentioned this pull request Jan 26, 2021
Closed
@katre katre changed the title [WIP] Enable toolchain resolution for filegroup targets. Enable toolchain resolution for filegroup targets. Jan 26, 2021
@katre katre requested a review from gregestren January 26, 2021 21:42
@katre katre marked this pull request as ready for review January 26, 2021 21:42
@gregestren gregestren added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Jan 26, 2021
@bazel-io bazel-io closed this in dfb70ea Jan 27, 2021
@katre katre deleted the i12899-filegroup-platforms branch January 27, 2021 15:33
philwo pushed a commit that referenced this pull request Mar 15, 2021
@katre @philwo
Enable toolchain resolution for filegroup targets.
f966749 
Fixes #12899.

Closes #12901.

PiperOrigin-RevId: 354087352
philwo pushed a commit that referenced this pull request Mar 15, 2021
@katre @philwo
Enable toolchain resolution for filegroup targets.
99aa968 
Fixes #12899.

Closes #12901.

PiperOrigin-RevId: 354087352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren gregestren approved these changes

Assignees
No one assigned
Labels
cla: yes team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate whether filegroup can use platform-conditional selects
2 participants
@katre @gregestren